chore: delete redundant Java header files #1120
Conversation
WalkthroughThe changes focus on optimizing and cleaning up the configuration of Changes
Poem
Tip Early access features
Note:
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
caicancai
changed the title
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (2)
- jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java (1 hunks)
- jraft-core/src/test/java/com/alipay/sofa/jraft/core/NodeTest.java (1 hunks)
Files skipped from review due to trivial changes (1)
- jraft-core/src/test/java/com/alipay/sofa/jraft/core/NodeTest.java
Additional comments not posted (1)
jraft-core/src/main/java/com/alipay/sofa/jraft/core/NodeImpl.java (1)
988-993: Reformatting Method Chaining forapplyDisruptorConfigurationThe reformatting of the
applyDisruptorconfiguration improves readability by consolidating the method chaining into a single line. This is a subjective change and aligns with the code style preferences.- this.applyDisruptor = DisruptorBuilder.<LogEntryAndClosure> newInstance() - .setRingBufferSize(this.raftOptions.getDisruptorBufferSize()) - .setEventFactory(new LogEntryAndClosureFactory()) - .setThreadFactory(new NamedThreadFactory("JRaft-NodeImpl-Disruptor-", true)) // - .setProducerType(ProducerType.MULTI) - .setWaitStrategy(new BlockingWaitStrategy()) - .build(); + this.applyDisruptor = DisruptorBuilder.<LogEntryAndClosure> newInstance().setRingBufferSize(this.raftOptions.getDisruptorBufferSize()).setEventFactory(new LogEntryAndClosureFactory()).setThreadFactory(new NamedThreadFactory("JRaft-NodeImpl-Disruptor-", true)).setProducerType(ProducerType.MULTI).setWaitStrategy(new BlockingWaitStrategy()).build();
caicancai
changed the title
|
cc @fengjiachun PATL， thanks |
Motivation:
as titile
Modification:
Describe the idea and modifications you've done.
Result:
Fixes #.
If there is no issue then describe the changes introduced by this PR.
Summary by CodeRabbit
Refactor
applyDisruptorto enhance code readability and maintainability.Tests
NodeTest.javato clean up the test dependencies.